This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 15, 2015, 7:45 p.m.)

Review request for Aurora, Bill Farner and Zameer Manji.


Improve thrift 0.9.1 build.

+ Use a more flexible .gitignore with an eye to future thrift upgrades.
+ Use a more portable sha256 hash command.
+ Apply a patch that made it into thrift 0.9.2 that improves the
  robustness of the 0.9.1 build across platforms.

 build-support/thrift/.gitignore |  6 ++----
 build-support/thrift/Makefile   | 12 ++++++++++--
 2 files changed, 12 insertions(+), 6 deletions(-)

Repository: aurora


This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where

 build-support/thrift/.gitignore |  7 ++++---
 build-support/thrift/Makefile   | 47 
 2 files changed, 42 insertions(+), 12 deletions(-)

Diffs (updated)

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


John Sirois

Reply via email to