----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review108751 -----------------------------------------------------------
You, sir are a wizard! To add some weight to this change, can you update the description with a minimal Dockerfile preamble? e.g. currently it's ``` FROM ubuntu:trusty RUN apt-get update && apt-get -y install \ libapr1-dev \ libcurl4-nss-dev \ libsvn-dev \ python-all-dev ``` - Bill Farner On Dec. 2, 2015, 3:57 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40889/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 3:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Changed mesos native lib to use mesos.executor instead > > Without any context this doesnt really make any sense. > > I've created a seperate mesos native lib that only contains a minimal set of > code needed to run the ExecutorDriver. This library has very few > requirements, making it a much better option for running in docker > containers, as well as allowing a thermos_executor.pex built on one linux > distro to run on most others. > > The mesos side of this is here: > https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8 > and I'll be opening a RB request on the mesos side soon. > > > Diffs > ----- > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > src/main/python/apache/aurora/executor/BUILD > 0be65fc7c180d15f5a94bef268652ef7b868dcf7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > > Diff: https://reviews.apache.org/r/40889/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
