> On Dec. 2, 2015, 4:36 p.m., Maxim Khutornenko wrote: > > 3rdparty/python/BUILD, line 14 > > <https://reviews.apache.org/r/40889/diff/1/?file=1151864#file1151864line14> > > > > Am I reading this as revving up mesos native version in Aurora? If so, > > we should also update build.gradle and possibly update > > make-mesos-native-egg script. Previous effort as a reference: > > https://reviews.apache.org/r/37379 > > Bill Farner wrote: > You're right, Maxim. I think it's safe to say this patch is still in PoC > stage, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. > > Steve Niemitz wrote: > Correct, I'll ping when I'm ready for more eyes on it. > > Zameer Manji wrote: > If you do want to do this, please assign > https://issues.apache.org/jira/browse/AURORA-1543 to yourself. > > Steve Niemitz wrote: > The version number here is pretty much a placeholder, what it ends up > being is going to depend on how we want to support the mesos native library. > I see a couple options (and maybe there's others): > 1. Wait for my patch (which I'm about to submit (1)) to land in mesos and > let the normal aurora->mesos upgrade cycle get it. It will be at least > 0.26.0 in this case, as 0.25.0 is already released. > 2. Host our own builds of mesos.executor somewhere, and download/use that > when doing the thermos build. We could build it off of pretty much any mesos > version, including the current 0.23.0. > > Seeing as mesos proper doesn't provide debs/rpms anyways (mesospehere > does instead), and the same mesos.executor egg *should* work in either centos > or ubuntu, option 2 might make the most sense, especially if we want to get > this out sometime soon. > > (1): https://issues.apache.org/jira/browse/MESOS-4090
I could be convinced of (2), so long as we can point to the sha we built from + patch we applied. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review108758 ----------------------------------------------------------- On Dec. 2, 2015, 3:57 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40889/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 3:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Changed mesos native lib to use mesos.executor instead > > Without any context this doesnt really make any sense. > > I've created a seperate mesos native lib that only contains a minimal set of > code needed to run the ExecutorDriver. This library has very few > requirements, making it a much better option for running in docker > containers, as well as allowing a thermos_executor.pex built on one linux > distro to run on most others. > > The mesos side of this is here: > https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8 > and I'll be opening a RB request on the mesos side soon. > > > Diffs > ----- > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > src/main/python/apache/aurora/executor/BUILD > 0be65fc7c180d15f5a94bef268652ef7b868dcf7 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > > Diff: https://reviews.apache.org/r/40889/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
