> On Dec. 11, 2015, 5:20 a.m., Stephan Erb wrote:
> > src/main/python/apache/thermos/core/runner.py, line 718
> > <https://reviews.apache.org/r/30695/diff/4/?file=1147024#file1147024line718>
> >
> >     I am not sure if it is a good idea to always enforce the gloabal 
> > settings, instead of using them as a default value in case a process has no 
> > logger configuration.
> >     
> >     I see no harm in allowing a user to override the global default. 
> > Afterall, it will be his disk quota / resources that will be affected by 
> > disabling the rotation.
> 
> George Sirois wrote:
>     No objection to this approach either. It's probably the most flexible 
> policy, and, as you said, will only affect the individual job owners if they 
> decide to do something different than the default.
>     
>     Bill, any objections?

Fine by me.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30695/#review109957
-----------------------------------------------------------


On Nov. 25, 2015, 9 a.m., George Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30695/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 9 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-95
>     https://issues.apache.org/jira/browse/AURORA-95
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implements log rotation in the Thermos runner.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b3e8bf1e924999306e0b8a1314273b22c51028e7 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 14e8b4bd539d2c295582d93fa01b5613345c1758 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/core/runner.py 
> f949f279a071c6464b026749f51afc776102f2aa 
>   src/main/python/apache/thermos/runner/thermos_runner.py 
> bd8cf7f4cda54b6be72dad64f9446eedeb132211 
>   src/test/python/apache/thermos/core/test_process.py 
> 5e6ad2fca616b840299bd9ca1614c82c5c39e992 
> 
> Diff: https://reviews.apache.org/r/30695/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/core:all
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Reply via email to