----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review111023 -----------------------------------------------------------
Master (c912c34) is red with this patch. ./build-support/jenkins/build.sh virtualenv-12.1.1/virtualenv_support/__init__.py virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl + touch virtualenv-12.1.1/BOOTSTRAPPED + popd ~/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip...done. You are using pip version 6.1.1, however version 7.1.2 is available. You should consider upgrading via the 'pip install --upgrade pip' command. Collecting isort==4.0.0 Using cached isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_base.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_base.py:before 2015-12-17 19:35:33.439546 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/schema_base.py:after 2015-12-17 19:40:34.485465 @@ -14,7 +14,19 @@ # checkstyle: noqa -from pystachio import Boolean, Default, Empty, Enum, Float, Integer, List, Map, Required, String, Struct +from pystachio import ( + Boolean, + Default, + Empty, + Enum, + Float, + Integer, + List, + Map, + Required, + String, + Struct +) # Define constants for resources BYTES = 1 I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 17, 2015, 5:22 p.m., George Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30695/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 5:22 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: AURORA-95 > https://issues.apache.org/jira/browse/AURORA-95 > > > Repository: aurora > > > Description > ------- > > Implements log rotation in the Thermos runner. > > > Diffs > ----- > > docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 > docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > b3e8bf1e924999306e0b8a1314273b22c51028e7 > src/main/python/apache/aurora/executor/thermos_task_runner.py > 14e8b4bd539d2c295582d93fa01b5613345c1758 > src/main/python/apache/thermos/config/schema_base.py > f9143cc1b83143d6147f59d90c79435d055d0518 > src/main/python/apache/thermos/core/process.py > fe95cb3be01b47616596bd78cb9a919b2e8bd978 > src/main/python/apache/thermos/core/runner.py > f949f279a071c6464b026749f51afc776102f2aa > src/main/python/apache/thermos/runner/thermos_runner.py > bd8cf7f4cda54b6be72dad64f9446eedeb132211 > src/test/python/apache/thermos/core/test_process.py > 5e6ad2fca616b840299bd9ca1614c82c5c39e992 > > Diff: https://reviews.apache.org/r/30695/diff/ > > > Testing > ------- > > ./pants test src/test/python/apache/thermos/core:all > > > Thanks, > > George Sirois > >
