> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > This built fine for me, and installed fine as well, but the resulting 
> > scheduler has stdout and stderr attached to /dev/null which needs to be 
> > fixed (no logs).  I had a harder time than I might resoning through things 
> > since this setup re-uses the ubuntu init arrangement, but under systemd.  
> > This means systemd generates a unit file on the fly to bridge the sysv 
> > init.  Had you thought about this extra indirection?  It seems like it 
> > would be easier to deal with a direct systemd setup / unit file like the 
> > centos builder has.

Yup, talked offline and now you can see the logs via 'journalctl -u 
aurora-scheduler'. 1,2 fds are no longer going to /dev/null. 

java    31858 aurora    1u  unix 0xffff880036c01bc0      0t0 140592 socket
java    31858 aurora    2u  unix 0xffff880036c01bc0      0t0 140592 socket

For record keeping, this was done via --no-close option to stop-start-daemon


> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > builder/deb/debian-jessie/build.sh, line 40
> > <https://reviews.apache.org/r/42387/diff/1/?file=1199230#file1199230line40>
> >
> >     What's this? Cruft to kill?

Done.


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114872
-----------------------------------------------------------


On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -----
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> -------
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to