----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115480 -----------------------------------------------------------
Ship it! This lgtm. I re-ran through fresh builds of all packages and tested both the debian-jessie and ubuntu-trusty installs worked, logs were present in the expected system location (journalctl vs /var/log/upstart), and that the scheduler and observer both correctly re-spawned when killed. NB: Our standard review procedure is last reviewer patches in unless there are very large delays - so hang on for more feedback from others. - John Sirois On Jan. 19, 2016, 5:59 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42387/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 5:59 p.m.) > > > Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner. > > > Repository: aurora-packaging > > > Description > ------- > > Adding debian jessie packaging with a test. > > > Diffs > ----- > > build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 > builder/deb/debian-jessie/Dockerfile PRE-CREATION > builder/deb/debian-jessie/build.sh PRE-CREATION > builder/deb/debian-jessie/pants.ini PRE-CREATION > specs/debian/aurora-executor.thermos.init > e5c940147f5f0a1842d15be9bb9c44e838bc9af0 > specs/debian/aurora-executor.thermos.service PRE-CREATION > specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 > specs/debian/aurora-scheduler.service PRE-CREATION > specs/debian/aurora-scheduler.upstart > 1ceb7042485efedcf7136b51737107aada4c4e96 > specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 > test/deb/debian-jessie/README.md PRE-CREATION > test/deb/debian-jessie/Vagrantfile PRE-CREATION > test/deb/debian-jessie/provision.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/42387/diff/ > > > Testing > ------- > > New build with a test that starts a Vagrant and following README should lead > to a successful job. > > > Thanks, > > Dmitriy Shirchenko > >
