> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote: > > build-artifact.sh, line 35 > > <https://reviews.apache.org/r/42387/diff/4/?file=1202375#file1202375line35> > > > > How about a selective `set -x`, `set +x` around the commands you wish > > to see echoed instead?
Removed. Adding set -x, set +x to my arsenal when debugging shell scripts. Thanks. > On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote: > > builder/deb/debian-jessie/Dockerfile, line 37 > > <https://reviews.apache.org/r/42387/diff/4/?file=1202376#file1202376line37> > > > > FYI - the deb has a build-time dep of a package named 'gradle', so it > > would be slightly more involved than that. Thanks. Clarified comment. > On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote: > > builder/deb/debian-jessie/build.sh, line 1 > > <https://reviews.apache.org/r/42387/diff/4/?file=1202377#file1202377line1> > > > > Checking my recollection - this can't be a symlink due to the way it's > > mounted with docker, right? If that's correct, can you leave a TODO for me > > to figure out how to share these files? Sure. There could be an easy way to mounting the file into the container, but yea, leaving a TODO. > On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote: > > specs/debian/aurora-executor.thermos.init, lines 43-44 > > <https://reviews.apache.org/r/42387/diff/4/?file=1202379#file1202379line43> > > > > Is this necessary due to `app_daemonize` or is there more to it? im not really sure tbh. these were suggestions from +benley. but are you asking about the format change or log_dir change? log_to_disk was supposed to make it consistent and it was told me to it's better. i am not sure what log_dir was before, but now it's explicit and i see logs going there. - Dmitriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115532 ----------------------------------------------------------- On Jan. 20, 2016, 12:59 a.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42387/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 12:59 a.m.) > > > Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner. > > > Repository: aurora-packaging > > > Description > ------- > > Adding debian jessie packaging with a test. > > > Diffs > ----- > > build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 > builder/deb/debian-jessie/Dockerfile PRE-CREATION > builder/deb/debian-jessie/build.sh PRE-CREATION > builder/deb/debian-jessie/pants.ini PRE-CREATION > specs/debian/aurora-executor.thermos.init > e5c940147f5f0a1842d15be9bb9c44e838bc9af0 > specs/debian/aurora-executor.thermos.service PRE-CREATION > specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 > specs/debian/aurora-scheduler.service PRE-CREATION > specs/debian/aurora-scheduler.upstart > 1ceb7042485efedcf7136b51737107aada4c4e96 > specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 > test/deb/debian-jessie/README.md PRE-CREATION > test/deb/debian-jessie/Vagrantfile PRE-CREATION > test/deb/debian-jessie/provision.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/42387/diff/ > > > Testing > ------- > > New build with a test that starts a Vagrant and following README should lead > to a successful job. > > > Thanks, > > Dmitriy Shirchenko > >
