> On March 29, 2016, 12:03 a.m., Joshua Cohen wrote: > > Are there any concerns about any other unintended side effect of setting > > $HOME to the sandbox? I suppose it's opt-in for now, so that allays most > > fears. > > George Sirois wrote: > I couldn't think of any (nor did I discover any in testing, both with and > without Docker), but making it opt-in should allow us to gain experience with > running it in production environments without impacting existing deployments. > The reason I used HOME (as opposed to PEX_ROOT) is that the executor strips > PEX_ROOT before forking the runner, which has the same issue. We could add > some plumbing to get around that, but it seems like if you're running with a > read-only root FS, you'd want HOME to be a writable location anyway.
Yeah, I'm not coming up with anything either other than potentially causing tasks to exceed their disk space allotment due to ~/.pex/install now being counted against them. That's arguably the right thing to do though, operators should just be cognizant of that when enabling this (or if/when we make it the default). - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125779 ----------------------------------------------------------- On March 28, 2016, 6:21 p.m., George Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45396/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 6:21 p.m.) > > > Review request for Aurora, Joshua Cohen, Steve Niemitz, and Bill Farner. > > > Repository: aurora > > > Description > ------- > > In instances where the root filesystem is read-only, it is desirable to > have the executor/runner extract themselves into the sandbox. > > > Diffs > ----- > > RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 > docs/deploying-aurora-scheduler.md 03bfdbab927c924486b04c42df2ad236c0f414a0 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 949c299bdbc54f976db994266fb97f3099256f13 > > Diff: https://reviews.apache.org/r/45396/diff/ > > > Testing > ------- > > > Thanks, > > George Sirois > >
