----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125887 -----------------------------------------------------------
Ship it! LGTM, thanks for adding the tests! If you don't mind fixing the two style nits below I can commit this. src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java (line 112) <https://reviews.apache.org/r/45396/#comment188786> nit: +blank line before src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModuleTest.java (line 71) <https://reviews.apache.org/r/45396/#comment188788> same style nit here, blank line after method signature that's broken up over multiple lines. - Joshua Cohen On March 29, 2016, 5:49 a.m., George Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45396/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 5:49 a.m.) > > > Review request for Aurora, Joshua Cohen, Steve Niemitz, and Bill Farner. > > > Repository: aurora > > > Description > ------- > > In instances where the root filesystem is read-only, it is desirable to > have the executor/runner extract themselves into the sandbox. > > > Diffs > ----- > > RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 > config/legacy_untested_classes.txt 144b258b7a7f73131f07826a0fdcac04834d87db > docs/operations/configuration.md f9e8844914b7af2b0057ca5f1d7d4391a63ca142 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 949c299bdbc54f976db994266fb97f3099256f13 > > src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModuleTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45396/diff/ > > > Testing > ------- > > > Thanks, > > George Sirois > >
