> On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/base/Conversions.java, line 67 > > <https://reviews.apache.org/r/54255/diff/2/?file=1578557#file1578557line67> > > > > Can you reference AURORA-1814 in this comment please?
Done > On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote: > > build-support/python/make-mesos-native-egg, line 61 > > <https://reviews.apache.org/r/54255/diff/2/?file=1578555#file1578555line61> > > > > I think here we want to set the `MAKEFLAGS` environment variable > > instead. > > > > > > https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html > > > > ``` > > The ‘-j’ option is a special case (see Parallel Execution). If you set > > it to some numeric value ‘N’ and your operating system supports it (most > > any UNIX system will; others typically won’t), the parent make and all the > > sub-makes will communicate to ensure that there are only ‘N’ jobs running > > at the same time between them all. Note that any job that is marked > > recursive (see Instead of Executing Recipes) doesn’t count against the > > total jobs (otherwise we could get ‘N’ sub-makes running and have no slots > > left over for any real work!) > > ``` > > > > I think the mesos make files have recursive make invocations in them, > > so this is more desirable. Done > On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote: > > RELEASE-NOTES.md, line 5 > > <https://reviews.apache.org/r/54255/diff/2/?file=1578552#file1578552line5> > > > > You mean 1.1.0 right? Fixed - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158370 ----------------------------------------------------------- On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54255/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2016, 1:05 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1813 > https://issues.apache.org/jira/browse/AURORA-1813 > > > Repository: aurora > > > Description > ------- > > Included changes: > > * Handle new task states introduced in the latest Mesos release. > * Prevent NullPointer exception when inspecting an empty/invalid executor > config in a test. > Probably this is due to a change in the Mesos protobufs. > * Fix bug preventing the teardown of Vagrant boxes started by the egg build. > * Increase resources for the Mesos egg builds. The build for all distribution > now takes 2h in total. > > Full Mesos changelog: > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0 > > > Diffs > ----- > > 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126 > RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3 > Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4 > build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd > build-support/python/make-mesos-native-egg > bcc6e85abb7536002afb3071c08e2008bcc1ecca > build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > 4a1e0876609ce8eda457c0174e3ea3fbb8609376 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java > 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5 > > Diff: https://reviews.apache.org/r/54255/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants test.pytest src/{main,test}/python:: -- -v > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos > 1.0 and Mesos 1.1) > > > Thanks, > > Stephan Erb > >
