> On Dec. 7, 2016, 7:14 p.m., David McLaughlin wrote: > > Re: Testing Done. Can you verify this build of Aurora also runs on Mesos > > 1.0.0, even if it's just manual verification? I'm not sure the implication > > of using those constants - were they also in Mesos 1.0.0? > > Zameer Manji wrote: > The constatns were not in the Mesos 1.0.0 protbuf, but they are here now. > > We cannot recieve these task states against Mesos 1.0.0 because the > feature didn't exist. We cannot recieve these task states in Mesos 1.1.0 > because we do not opt in to these new states. I filed AURORA-1814 to consider > opting in. > > However, we need to create a mapping because the generated code has the > new entries in the enum. I hope this clears up any concerns.
I downgraded Mesos to 1.0 in our Vagrant box and re-run the e2e tests. Everything passed. - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158359 ----------------------------------------------------------- On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54255/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2016, 1:05 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1813 > https://issues.apache.org/jira/browse/AURORA-1813 > > > Repository: aurora > > > Description > ------- > > Included changes: > > * Handle new task states introduced in the latest Mesos release. > * Prevent NullPointer exception when inspecting an empty/invalid executor > config in a test. > Probably this is due to a change in the Mesos protobufs. > * Fix bug preventing the teardown of Vagrant boxes started by the egg build. > * Increase resources for the Mesos egg builds. The build for all distribution > now takes 2h in total. > > Full Mesos changelog: > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0 > > > Diffs > ----- > > 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126 > RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3 > Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4 > build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd > build-support/python/make-mesos-native-egg > bcc6e85abb7536002afb3071c08e2008bcc1ecca > build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > 4a1e0876609ce8eda457c0174e3ea3fbb8609376 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java > 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5 > > Diff: https://reviews.apache.org/r/54255/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants test.pytest src/{main,test}/python:: -- -v > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos > 1.0 and Mesos 1.1) > > > Thanks, > > Stephan Erb > >
