> On Dec. 8, 2016, 4:42 p.m., Zameer Manji wrote:
> > Does anyone know how to get the test reports from jenkins or have an idea
> > of what's going on?
Yes, these are legit failures, no Jenkins logs needed, just this is enough:
```
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest >
testAbdicateTransition FAILED
java.lang.AssertionError at CuratorSingletonServiceTest.java:125
java.lang.AssertionError
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest >
testLeadAdvertise FAILED
java.lang.AssertionError at CuratorSingletonServiceTest.java:94
java.lang.AssertionError
```
I looked at the testLeadAdvertise one 1st which [blocks until an ephemeral node
is
added](https://github.com/apache/aurora/blob/master/src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java#L82-L83)
to the leadership group path as the signal that leadership has been already
synchronously obtained. The assumption is broken with LeaderSelector since the
transition is [fired on an executor
runnable](https://github.com/apache/curator/blob/master/curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java#L239)
and could be delayed arbitrarily past the test assertion.
In short, you're getting lucky having these 2 (and maybe more) pass on your
machine. Needs careful re-review of the test infra and the new behavior of the
LeaderSelector using the thread pool to do leadership transitions async.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review158601
-----------------------------------------------------------
On Dec. 8, 2016, 4:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 4:28 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and
> Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
> 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> c378172c850aafe0a9381552b5067277b40dbfab
>
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
> a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
> 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
