-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review158599
-----------------------------------------------------------
Master (f5749ce) is red with this patch.
./build-support/jenkins/build.sh
at
org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
at
org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)
at
org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:293)
at
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
:pmdTest
:test
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest >
testAbdicateTransition FAILED
java.lang.AssertionError at CuratorSingletonServiceTest.java:125
java.lang.AssertionError
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest >
testLeadAdvertise FAILED
java.lang.AssertionError at CuratorSingletonServiceTest.java:94
java.lang.AssertionError
I1208 23:33:14.100 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1068 tests completed, 2 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.887991790582404, but must be greater than 0.89
Branch coverage is 0.8021539688871161, but must be greater than 0.835
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 4 mins 19.969 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 8, 2016, 11:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 11:28 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and
> Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
> 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> c378172c850aafe0a9381552b5067277b40dbfab
>
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
> a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
> 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
