-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193592
-----------------------------------------------------------
Master (301f066) is red with this patch.
./build-support/jenkins/build.sh
Pass 2: Analyzing classes (312 / 325) - 96% complete
Pass 2: Analyzing classes (313 / 325) - 96% complete
Pass 2: Analyzing classes (314 / 325) - 96% complete
Pass 2: Analyzing classes (315 / 325) - 96% complete
Pass 2: Analyzing classes (316 / 325) - 97% complete
Pass 2: Analyzing classes (317 / 325) - 97% complete
Pass 2: Analyzing classes (318 / 325) - 97% complete
Pass 2: Analyzing classes (319 / 325) - 98% complete
Pass 2: Analyzing classes (320 / 325) - 98% complete
Pass 2: Analyzing classes (321 / 325) - 98% complete
Pass 2: Analyzing classes (322 / 325) - 99% complete
Pass 2: Analyzing classes (323 / 325) - 99% complete
Pass 2: Analyzing classes (324 / 325) - 99% complete
Pass 2: Analyzing classes (325 / 325) - 100% complete
Done with analysis
:test
org.apache.aurora.scheduler.events.WebhookTest >
testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:191
I1212 19:15:59.633 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1065 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 4m 55s
44 actionable tasks: 35 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 12, 2017, 7:15 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64523/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 7:15 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Bugs: AURORA-1961
> https://issues.apache.org/jira/browse/AURORA-1961
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Attempt #2 to fix the flaky Webhook test.
>
> Along the same lines of Stephan's change
> (https://reviews.apache.org/r/64482/), but waiting for `onThrowable` to
> finish since it is called asyncronously to the future being completed.
>
> Overall, this flakiness has seemed to increase in volume over the past month.
> I've been running into it with a noticable fraction of internal/test builds.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> 1b5d2d02535345edfe6cf04d18d00434393f800b
>
>
> Diff: https://reviews.apache.org/r/64523/diff/2/
>
>
> Testing
> -------
>
> This change seems pretty hard to test considering the differences in
> environment and the unknown cause of the actual errors. Maybe we run the
> reviewbot on this repo repeatedly? Obviously not the most scientifically
> sound solution.
>
> EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which
> causes the issue in master and is fixed with this patch.
>
>
> Thanks,
>
> Jordan Ly
>
>
