----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193616 -----------------------------------------------------------
Ship it! Ship It! - Stephan Erb On Dec. 12, 2017, 8:15 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64523/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2017, 8:15 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Bugs: AURORA-1961 > https://issues.apache.org/jira/browse/AURORA-1961 > > > Repository: aurora > > > Description > ------- > > Attempt #2 to fix the flaky Webhook test. > > Along the same lines of Stephan's change > (https://reviews.apache.org/r/64482/), but waiting for `onThrowable` to > finish since it is called asyncronously to the future being completed. > > Overall, this flakiness has seemed to increase in volume over the past month. > I've been running into it with a noticable fraction of internal/test builds. > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 1b5d2d02535345edfe6cf04d18d00434393f800b > > > Diff: https://reviews.apache.org/r/64523/diff/2/ > > > Testing > ------- > > This change seems pretty hard to test considering the differences in > environment and the unknown cause of the actual errors. Maybe we run the > reviewbot on this repo repeatedly? Obviously not the most scientifically > sound solution. > > EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which > causes the issue in master and is fixed with this patch. > > > Thanks, > > Jordan Ly > >
