> On Dec. 12, 2017, 10:46 p.m., Aurora ReviewBot wrote:
> > Master (301f066) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m # Create file stdout for capturing output.
> > We can't use StringIO mock[0m
> > [1m # because TestProcess is running fork.[0m
> > [1m with open(os.path.join(td, 'sys_stdout'),
> > 'w+') as stdout:[0m
> > [1m with open(os.path.join(td,
> > 'sys_stderr'), 'w+') as stderr:[0m
> > [1m with mutable_sys():[0m
> > [1m sys.stdout, sys.stderr = stdout,
> > stderr[0m
> > [1m [0m
> > [1m p = TestProcess('process', 'echo
> > hello world; echo >&2 hello stderr', 0,[0m
> > [1m taskpath, sandbox,
> > logger_destination=LoggerDestination.BOTH)[0m
> > [1m p.start()[0m
> > [1m rc =
> > wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
> > [1m [0m
> > [1m assert rc == 0[0m
> > [1m # Check log files were created in
> > std path with correct content[0m
> > [1m> assert_log_content(taskpath,
> > 'stdout', 'hello world\n')[0m
> >
> >
> > src/test/python/apache/thermos/core/test_process.py:538:
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> >
> > taskpath = <apache.thermos.common.path.TaskPath object
> > at 0x7f9138423590>
> > log_name = 'stdout'
> > expected_content = 'hello world\n'
> >
> > [1m def assert_log_content(taskpath, log_name,
> > expected_content):[0m
> > [1m log =
> > taskpath.with_filename(log_name).getpath('process_logdir')[0m
> > [1m assert os.path.exists(log)[0m
> > [1m with open(log, 'r') as fp:[0m
> > [1m> assert fp.read() == expected_content[0m
> > [1m[31mE assert '' == 'hello world\n'[0m
> > [1m[31mE + hello world[0m
> >
> >
> > src/test/python/apache/thermos/core/test_process.py:364: AssertionError
> > generated xml file:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
> >
> > [1m[31m 1 failed, 794 passed, 6 skipped, 1 warnings
> > in 461.64 seconds [0m
> >
> > FAILURE
> >
> >
> > 21:46:32 08:16 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
>
> Jordan Ly wrote:
> I've never seen this fail before :(
This is just not our week :)
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193608
-----------------------------------------------------------
On Dec. 12, 2017, 8:15 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64523/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 8:15 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Bugs: AURORA-1961
> https://issues.apache.org/jira/browse/AURORA-1961
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Attempt #2 to fix the flaky Webhook test.
>
> Along the same lines of Stephan's change
> (https://reviews.apache.org/r/64482/), but waiting for `onThrowable` to
> finish since it is called asyncronously to the future being completed.
>
> Overall, this flakiness has seemed to increase in volume over the past month.
> I've been running into it with a noticable fraction of internal/test builds.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> 1b5d2d02535345edfe6cf04d18d00434393f800b
>
>
> Diff: https://reviews.apache.org/r/64523/diff/2/
>
>
> Testing
> -------
>
> This change seems pretty hard to test considering the differences in
> environment and the unknown cause of the actual errors. Maybe we run the
> reviewbot on this repo repeatedly? Obviously not the most scientifically
> sound solution.
>
> EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which
> causes the issue in master and is fixed with this patch.
>
>
> Thanks,
>
> Jordan Ly
>
>
