----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65076/#review195167 -----------------------------------------------------------
Thanks for the patch! Can you add a test to validate the final JSON form? That will be good insurance against breaking your usage in the future. `MnameTest.java` can serve as a guide for testing an HTTP endpoint. - Bill Farner On Jan. 10, 2018, 10:36 a.m., Juan Manuel Fresia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65076/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 10:36 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Signed-off-by: Juan Manuel Fresia <[email protected]> > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 1710e39f4fef9cba9d78cb097c889ac89bd04eb5 > > > Diff: https://reviews.apache.org/r/65076/diff/3/ > > > Testing > ------- > > Gradle verification/test target. > > > Thanks, > > Juan Manuel Fresia > >
