----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65076/#review195633 -----------------------------------------------------------
This patch does not apply cleanly against master (f6146eb), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 16, 2018, 11:20 a.m., Juan Manuel Fresia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65076/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 11:20 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added ExclusionStrategy to Gson formatter in structdump to hide trhift > metadata fields such as "__isset_bitfield" and the "optionals" enum. > Added a FieldNamingStrategy to rename "value_" and "setName_" fields to > "value" and "key" on map formatting. > Created test cases to cover the scenarios above. > > Signed-off-by: Juan Manuel Fresia <jfre...@medallia.com\> > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 1710e39f4fef9cba9d78cb097c889ac89bd04eb5 > src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65076/diff/5/ > > > Testing > ------- > > Gradle verification/test target. > > > Thanks, > > Juan Manuel Fresia > >