----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65076/#review195659 -----------------------------------------------------------
Ship it! Thanks for the patch! This is now on master ```console $ git log -1 origin/master commit 8a5dcac (HEAD -> master, origin/master, origin/HEAD) Author: Juan Manuel Fresia <jfre...@medallia.com> Date: Wed Jan 17 15:02:26 2018 -0800 Added ExclusionStrategy to Gson formatter in structdump This hides thrift metadata fields such as "__isset_bitfield" and the "optionals" enum. Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting. Reviewed at https://reviews.apache.org/r/65076/ ``` - Bill Farner On Jan. 17, 2018, 11:15 a.m., Juan Manuel Fresia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65076/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 11:15 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added ExclusionStrategy to Gson formatter in structdump to hide trhift > metadata fields such as "__isset_bitfield" and the "optionals" enum. > Added a FieldNamingStrategy to rename "value_" and "setName_" fields to > "value" and "key" on map formatting. > Created test cases to cover the scenarios above. > > Signed-off-by: Juan Manuel Fresia <jfre...@medallia.com\> > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 1710e39f4fef9cba9d78cb097c889ac89bd04eb5 > src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65076/diff/6/ > > > Testing > ------- > > Gradle verification/test target. > > > Thanks, > > Juan Manuel Fresia > >