> On April 9, 2018, 3:33 p.m., Renan DelValle wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 1263 (patched) > > <https://reviews.apache.org/r/66490/diff/4/?file=1993661#file1993661line1272> > > > > I think the better solution here would be to make Volume.hostPath > > optional and handle hostPath not being set at the Java server side. Maybe > > have hostPath mirror to VolumeSource.hostpath while it is being deprecated. > > > > This can be done somewhere in > > `src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java` > > Justin Venus wrote: > Will it break anything to make Volume.hostPath optional? It's my > unstanding that this is implicitly required now.
Yup, I didn't think this one through, sorry about that! We can leave `Volume.hostpath` as required while making `VolumeSource.hostpath` as optional for now. Then, on the scheduler side, if `VolumeSource` is set, we use that. If `VolumeSource` is not set, we create a new `VolumeSource` using `Volume.hostpath`. And finally, when we create the job, we rely on `VolumeSource` as the source of truth. That way, we can move to deprecate `Volume.hostpath` down the line since it becomes a proxy for what `VolumeSource` contains. - Renan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/#review200768 ----------------------------------------------------------- On April 6, 2018, 5:04 p.m., Justin Venus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66490/ > ----------------------------------------------------------- > > (Updated April 6, 2018, 5:04 p.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Bugs: AURORA-1983 > https://issues.apache.org/jira/browse/AURORA-1983 > > > Repository: aurora > > > Description > ------- > > This change implements the docker/volume isolator as described at > http://mesos.apache.org/documentation/latest/isolators/docker-volume/. > > * update config thrift tests to check for docker/volume isolator support > * update mesos task factory to support docker/volume isolator > * update documentation for docker/volume isolator support > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > bcb2bbf882f43d813dd26c746d806e78bae6bcf3 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/test/python/apache/aurora/config/test_thrift.py > 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 > > > Diff: https://reviews.apache.org/r/66490/diff/4/ > > > Testing > ------- > > Tests pass locally > ```sh > ./gradlew test > ./pants test src/test/python:: > ``` > > I've deployed this code to a test cluster with rexray, dvdcli, and the agents > have `docker/volume` isolation enabled. I am able to exercise mounting an > EBS volume as I would expect into a container. > > > Thanks, > > Justin Venus > >
