-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66490/
-----------------------------------------------------------
(Updated April 14, 2018, 1:52 a.m.)
Review request for Aurora, Renan DelValle and Stephan Erb.
Changes
-------
Transition from Volume.hostPath to Volume.source "@ReviewBot retry"
Bugs: AURORA-1983
https://issues.apache.org/jira/browse/AURORA-1983
Repository: aurora
Description (updated)
-------
This change implements the docker/volume isolator as described at
http://mesos.apache.org/documentation/latest/isolators/docker-volume/.
* behind the scenes upgrade configuration to VolumeSource
* guard against unset enum value while transitioning to VolumeSource
* replace Iterables.transform w/ Stream interface in MesosTaskFactory
* Use string for hostPath instead of struct
* update config thrift tests to check for docker/volume isolator support
* update mesos task factory to support docker/volume isolator
* update documentation for docker/volume isolator support
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift
ef754e32172e7490a47a13e7b526f243ffa3efeb
docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
4073229b74d0e0e7fd31552bd96894ceb8a0971a
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
bcb2bbf882f43d813dd26c746d806e78bae6bcf3
src/main/python/apache/aurora/config/schema/base.py
a629bcd1261e5959da0a8458a55545d4e2c2a7a5
src/main/python/apache/aurora/config/thrift.py
6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431
src/test/python/apache/aurora/config/test_thrift.py
8e1d0e177959af12b97bdd1cd47845b72bc12fe1
Diff: https://reviews.apache.org/r/66490/diff/7/
Changes: https://reviews.apache.org/r/66490/diff/6-7/
Testing
-------
Tests pass locally
```sh
./gradlew test
./pants test src/test/python::
```
I've deployed this code to a test cluster with rexray, dvdcli, and the agents
have `docker/volume` isolation enabled. I am able to exercise mounting an EBS
volume as I would expect into a container.
Thanks,
Justin Venus
