----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/#review200867 -----------------------------------------------------------
Ship it! Master (2d6108b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 11, 2018, 12:42 a.m., Justin Venus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66490/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 12:42 a.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Bugs: AURORA-1983 > https://issues.apache.org/jira/browse/AURORA-1983 > > > Repository: aurora > > > Description > ------- > > This change implements the docker/volume isolator as described at > http://mesos.apache.org/documentation/latest/isolators/docker-volume/. > > * Use string for hostPath instead of struct > * update config thrift tests to check for docker/volume isolator support > * update mesos task factory to support docker/volume isolator > * update documentation for docker/volume isolator support > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > bcb2bbf882f43d813dd26c746d806e78bae6bcf3 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/test/python/apache/aurora/config/test_thrift.py > 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 > > > Diff: https://reviews.apache.org/r/66490/diff/5/ > > > Testing > ------- > > Tests pass locally > ```sh > ./gradlew test > ./pants test src/test/python:: > ``` > > I've deployed this code to a test cluster with rexray, dvdcli, and the agents > have `docker/volume` isolation enabled. I am able to exercise mounting an > EBS volume as I would expect into a container. > > > Thanks, > > Justin Venus > >
