shanmugh commented on a change in pull request #37: Staggered (Variable batch)
Updates
URL: https://github.com/apache/aurora/pull/37#discussion_r220789381
##########
File path: src/main/python/apache/aurora/client/api/updater_util.py
##########
@@ -80,6 +84,18 @@ def to_thrift_update_settings(self, instances=None):
Arguments:
instances - optional list of instances to update.
"""
+
+ if self.update_strategy is Empty:
Review comment:
Should we update `self.batch_size` if the user specified an
`update_strategy`? Consider the case of a rolled scheduler, that is continuing
an in-progress update. In this case the update will suddenly slow-down to doing
1 (default) instance at a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
