shanmugh commented on a change in pull request #37: Staggered (Variable batch) Updates URL: https://github.com/apache/aurora/pull/37#discussion_r220789497
########## File path: src/main/python/apache/aurora/client/api/updater_util.py ########## @@ -16,40 +16,44 @@ from itertools import groupby from operator import itemgetter +from pystachio import Empty, Choice from twitter.common import log from gen.apache.aurora.api.ttypes import JobUpdateSettings, Range +from apache.aurora.config.schema.base import ( + BatchUpdateStrategy as PystachioBatchUpdateStrategy, + QueueUpdateStrategy as PystachioQueueUpdateStrategy, + VariableBatchUpdateStrategy as PystachioVariableBatchUpdateStrategy +) +from apache.aurora.config.thrift import create_update_strategy_config class UpdaterConfig(object): MIN_PULSE_INTERVAL_SECONDS = 60 - def __init__(self, - batch_size, - watch_secs, - max_per_shard_failures, - max_total_failures, - rollback_on_failure=True, - wait_for_batch_completion=False, - pulse_interval_secs=None, - sla_aware=None): - - if batch_size <= 0: + def __init__(self, config): + self.batch_size = config.batch_size().get() Review comment: It is going to be a little confusing when users specify both `batch_size` and `update_strategy`. Should we fail-fast in this case? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
