shanmugh commented on a change in pull request #37: Staggered (Variable batch)
Updates
URL: https://github.com/apache/aurora/pull/37#discussion_r220779603
##########
File path: src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
##########
@@ -76,12 +77,10 @@ Update newUpdate(
public Update newUpdate(IJobUpdateInstructions instructions, boolean
rollingForward) {
requireNonNull(instructions);
IJobUpdateSettings settings = instructions.getSettings();
+
checkArgument(
settings.getMinWaitInInstanceRunningMs() >= 0,
"Min wait in running must be non-negative.");
- checkArgument(
Review comment:
Although `JobUpdateInstructions` have been validated already via the thrift
API, checking `getMinWaitInInstanceRunningMs` and not `getUpdateGroupSize`
looks weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
