> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 
> > 318
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318>
> >
> >     why not initialize this inline?

Not sure I get it. Don't we need a handle to pull these mappings into test?


> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 
> > 629
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line629>
> >
> >     Extract the result of `op.getSetField()` into a temp variable?

Sure, done.


> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 
> > 652
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line652>
> >
> >     The full Op structure might be huge, consider just using the field name 
> > here.

Done.


> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 
> > 658
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line658>
> >
> >     use the field from a temp var above.

Done.


> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java, 
> > lines 412-415
> > <https://reviews.apache.org/r/27598/diff/1/?file=749748#file749748line412>
> >
> >     `assertEquals(Sets.complementOf(EnumSet.of(FRAME, 
> > DEDUPLICATED_SNAPSHOT, DEFLATED_ENTRY)), definedActions);`

That's a great suggestion! Done.


> On Nov. 5, 2014, 12:43 a.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java, 
> > lines 429-431
> > <https://reviews.apache.org/r/27598/diff/1/?file=749748#file749748line429>
> >
> >     `assertEquals(EnumSet.allOf(Op._Fields.class), definedActions);`

Same here.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/#review59893
-----------------------------------------------------------


On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27598/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:10 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-912
>     https://issues.apache.org/jira/browse/AURORA-912
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing the log replay for the job update history pruner.
> 
> Also, refactored LogStorage replay routine to fully test all 
> LogEntry/LogEntry.TRANSACTION handlers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> cbab75964052a950e1b868b3a53eb15fadb31cb7 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 8eb5c3f7c542206066b39a09911c7df01a43bee7 
> 
> Diff: https://reviews.apache.org/r/27598/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to