-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/#review59893
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/27598/#comment101203>

    why not initialize this inline?



src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/27598/#comment101205>

    Extract the result of `op.getSetField()` into a temp variable?



src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/27598/#comment101206>

    The full Op structure might be huge, consider just using the field name 
here.



src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/27598/#comment101207>

    use the field from a temp var above.



src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
<https://reviews.apache.org/r/27598/#comment101211>

    `assertEquals(Sets.complementOf(EnumSet.of(FRAME, DEDUPLICATED_SNAPSHOT, 
DEFLATED_ENTRY)), definedActions);`



src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
<https://reviews.apache.org/r/27598/#comment101208>

    `assertEquals(EnumSet.allOf(Op._Fields.class), definedActions);`


- Kevin Sweeney


On Nov. 4, 2014, 3:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27598/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 3:10 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-912
>     https://issues.apache.org/jira/browse/AURORA-912
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing the log replay for the job update history pruner.
> 
> Also, refactored LogStorage replay routine to fully test all 
> LogEntry/LogEntry.TRANSACTION handlers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> cbab75964052a950e1b868b3a53eb15fadb31cb7 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 8eb5c3f7c542206066b39a09911c7df01a43bee7 
> 
> Diff: https://reviews.apache.org/r/27598/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to