----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63421 -----------------------------------------------------------
src/main/python/apache/aurora/executor/aurora_executor.py <https://reviews.apache.org/r/28486/#comment105670> Should an uncaught Exception be TASK_LOST? presumably specific exceptions from user input can be TASK_FAILED. Is there a shallower exception class that you're certain comes from invalid user input? - Kevin Sweeney On Nov. 26, 2014, 3:48 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28486/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 3:48 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > Sandbox initialization is an operation that might fail and raise an exception. > By moving this into the try block the executor will return TASK_FAILED > instead of crashing when an exception is raised. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 79a24855b2a68271b7478395dfdadab8755c3af2 > > Diff: https://reviews.apache.org/r/28486/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:: > > > Thanks, > > Zameer Manji > >
