> On Dec. 1, 2014, 11:40 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py, line 132
> > <https://reviews.apache.org/r/28486/diff/2/?file=777033#file777033line132>
> >
> >     Should an uncaught Exception be TASK_LOST? presumably specific 
> > exceptions from user input can be TASK_FAILED.
> >     
> >     Is there a shallower exception class that you're certain comes from 
> > invalid user input?

The sandbox provider could be doing *anything* so any exception there I think 
is failure to start the task. I agree that having this wide type is bad but I 
am unsure on how to deal with this better.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28486/#review63421
-----------------------------------------------------------


On Nov. 26, 2014, 3:48 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28486/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 3:48 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Sandbox initialization is an operation that might fail and raise an exception.
> By moving this into the try block the executor will return TASK_FAILED 
> instead of crashing when an exception is raised.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 79a24855b2a68271b7478395dfdadab8755c3af2 
> 
> Diff: https://reviews.apache.org/r/28486/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to