-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/
-----------------------------------------------------------

(Updated Feb. 19, 2015, 11:58 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Bill's comments.

Also, realized the backup path is no longer covered by a write lock, added it 
in createSnapshot().


Bugs: AURORA-1108
    https://issues.apache.org/jira/browse/AURORA-1108


Repository: aurora


Description
-------

Wrapped backup file handling into Runnable to handle asynchronously. 

Refactoring somehow triggered a findbugs warning that I had to address as well:
"Exceptional return value of java.io.File.delete() ignored in 
org.apache.aurora.scheduler.storage.backup.StorageBackup$StorageBackupImpl$1.run()"


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
71feb5779df5738a92e587f9f66f915961f52d1d 
  src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 
a20378a01575c399c23c86aa784424fc6909c34e 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
ea33037d86f30f0787136f34dad34b88eceb0a4d 
  src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
7602d112d29454608a97ec81de14b6bf0c45df68 
  
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 
15fc4404fa2ace4391e4ddc7153c848bc91d43df 

Diff: https://reviews.apache.org/r/31171/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Reply via email to