> On Feb. 20, 2015, 12:06 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 261 > > <https://reviews.apache.org/r/31171/diff/2/?file=869995#file869995line261> > > > > It may exceed your appetite for this review, but i would actually > > prefer that this transaction be opened at the origin of the operation. > > This would mean `createSnapshot()` might be best to accept a > > `StoreProvider`, and allow the caller to decide whether that provider is > > part of a read or write transaction. If you follow this for > > `applySnapshot` as well, it could accept `MutableStoreProvider` and have no > > need to inject `Storage`.
(fwiw this advice is in line with other recent refactors [1] to push transactions up) [1] https://reviews.apache.org/r/26899/ - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73225 ----------------------------------------------------------- On Feb. 19, 2015, 11:58 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31171/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 11:58 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-1108 > https://issues.apache.org/jira/browse/AURORA-1108 > > > Repository: aurora > > > Description > ------- > > Wrapped backup file handling into Runnable to handle asynchronously. > > Refactoring somehow triggered a findbugs warning that I had to address as > well: > "Exceptional return value of java.io.File.delete() ignored in > org.apache.aurora.scheduler.storage.backup.StorageBackup$StorageBackupImpl$1.run()" > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java > 71feb5779df5738a92e587f9f66f915961f52d1d > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java > a20378a01575c399c23c86aa784424fc6909c34e > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > ea33037d86f30f0787136f34dad34b88eceb0a4d > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 7602d112d29454608a97ec81de14b6bf0c45df68 > > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java > 15fc4404fa2ace4391e4ddc7153c848bc91d43df > > Diff: https://reviews.apache.org/r/31171/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
