-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/#review73226
-----------------------------------------------------------
Master (e0e3f2e) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate
..... SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.cli.update
..... SUCCESS
src.test.python.apache.aurora.client.cli.version
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.factory
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer
..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout
..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
..... FAILURE
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 19, 2015, 11:58 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31171/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 11:58 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1108
> https://issues.apache.org/jira/browse/AURORA-1108
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Wrapped backup file handling into Runnable to handle asynchronously.
>
> Refactoring somehow triggered a findbugs warning that I had to address as
> well:
> "Exceptional return value of java.io.File.delete() ignored in
> org.apache.aurora.scheduler.storage.backup.StorageBackup$StorageBackupImpl$1.run()"
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java
> 71feb5779df5738a92e587f9f66f915961f52d1d
> src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java
> a20378a01575c399c23c86aa784424fc6909c34e
>
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
> ea33037d86f30f0787136f34dad34b88eceb0a4d
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java
> 7602d112d29454608a97ec81de14b6bf0c45df68
>
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java
> 15fc4404fa2ace4391e4ddc7153c848bc91d43df
>
> Diff: https://reviews.apache.org/r/31171/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
