> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
> >  lines 59-62
> > <https://reviews.apache.org/r/31820/diff/3/?file=889978#file889978line59>
> >
> >     Maybe move this to the ticket and kill the commented out code here?

Done.


> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java,
> >  lines 38-39
> > <https://reviews.apache.org/r/31820/diff/3/?file=889979#file889979line38>
> >
> >     nit: probably preferable to move ImmutableSortedSet.of down to the next 
> > line.

Fixed.


> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/common/clusters.py, line 92
> > <https://reviews.apache.org/r/31820/diff/3/?file=889983#file889983line92>
> >
> >     Is this change related?

Not sure what happened, rebased.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75926
-----------------------------------------------------------


On March 10, 2015, 12:45 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31820/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 12:45 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-809 and AURORA-811
>     https://issues.apache.org/jira/browse/AURORA-809
>     https://issues.apache.org/jira/browse/AURORA-811
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> * Add dependency on Apache Shiro.
> * HTTP Basic Authentication.
> * Authorization based on shiro.ini.
> * Sample shiro.ini for local mode.
> 
> 
> Diffs
> -----
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> 1e4ba014804b56a2ea02770d09beb63faaabf684 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 640acdf4e73f99418473ca97bcdc4f5f4c190f10 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
> 52fe0ea063dbc7a71a20926630bf449dbd936306 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31820/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> Local testing in the UI and with cURL.
> 
> Updates to e2e test and Vagrant environment to follow.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to