----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 -----------------------------------------------------------
Ship it! lgtm! src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java <https://reviews.apache.org/r/31820/#comment123255> Maybe move this to the ticket and kill the commented out code here? src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java <https://reviews.apache.org/r/31820/#comment123256> nit: probably preferable to move ImmutableSortedSet.of down to the next line. src/main/python/apache/aurora/common/clusters.py <https://reviews.apache.org/r/31820/#comment123258> Is this change related? src/test/python/apache/aurora/common/test_clusters.py <https://reviews.apache.org/r/31820/#comment123260> Same here, seems unrelated? Does this just need to be rebased? - Joshua Cohen On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31820/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 1:18 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-809 and AURORA-811 > https://issues.apache.org/jira/browse/AURORA-809 > https://issues.apache.org/jira/browse/AURORA-811 > > > Repository: aurora > > > Description > ------- > > * Add dependency on Apache Shiro. > * HTTP Basic Authentication. > * Authorization based on shiro.ini. > * Sample shiro.ini for local mode. > > > Diffs > ----- > > build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 24b61c1e4f615295acf28d904588e1512972d3f4 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 8a59d89c07b406ce98076ca7ee51b958599a39ec > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 1e4ba014804b56a2ea02770d09beb63faaabf684 > src/main/python/apache/aurora/common/clusters.py > c4b7fefca30313b281808478bf23158a9b7fbf85 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 640acdf4e73f99418473ca97bcdc4f5f4c190f10 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 52fe0ea063dbc7a71a20926630bf449dbd936306 > src/test/python/apache/aurora/common/test_clusters.py > 1bd696e9cd28d87d0cac68b33ab043407d796b61 > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/31820/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > Local testing in the UI and with cURL. > > Updates to e2e test and Vagrant environment to follow. > > > Thanks, > > Kevin Sweeney > >
