> On March 23, 2015, 10:43 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 61 > > <https://reviews.apache.org/r/32377/diff/1/?file=902302#file902302line61> > > > > Can you push the lazy instantiation logic to ModuleParser and change > > this back to Arg<Set<Module>>?
To be clear I suggest defining ```java private static final Arg<Set<Module>> SHIRO_REALM_MODULES = Arg.create(ImmutableSet.of(Modules.lazilyInstantiated(IniShiroRealmModule.class))); ``` - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77423 ----------------------------------------------------------- On March 22, 2015, 11:37 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32377/ > ----------------------------------------------------------- > > (Updated March 22, 2015, 11:37 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-1217 > https://issues.apache.org/jira/browse/AURORA-1217 > > > Repository: aurora > > > Description > ------- > > Add an indirection for modules that must not be statically instantiated. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/Modules.java > e95cb2a255e6986e0678a4085036deb24f9cb359 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > cc9cfd38239f909b8a77bd1a773e31ec30130d41 > src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/32377/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
