> On March 23, 2015, 6:56 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99 > > <https://reviews.apache.org/r/32377/diff/2/?file=903369#file903369line99> > > > > consider adding a Class<? extends Module>... overload.
-1 on the overload, +1 on the switch to that as the only implementation (since it's the only use case). - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77447 ----------------------------------------------------------- On March 23, 2015, 6:51 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32377/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 6:51 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-1217 > https://issues.apache.org/jira/browse/AURORA-1217 > > > Repository: aurora > > > Description > ------- > > Add an indirection for modules that must not be statically instantiated. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/Modules.java > e95cb2a255e6986e0678a4085036deb24f9cb359 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > cc9cfd38239f909b8a77bd1a773e31ec30130d41 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java > fe6409ab14ebfb89b161f919f764879d42e53877 > src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/32377/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
