narendly commented on a change in pull request #466: Integrate the WAGED
rebalancer with all the related components.
URL: https://github.com/apache/helix/pull/466#discussion_r324050208
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/AbstractTestClusterModel.java
##########
@@ -105,6 +105,7 @@ protected ResourceControllerDataProvider
setupClusterDataCache() throws IOExcept
testClusterConfig.setDisabledInstances(Collections.emptyMap());
testClusterConfig.setTopologyAwareEnabled(false);
testClusterConfig.setInstanceCapacityKeys(new
ArrayList<>(_capacityDataMap.keySet()));
+ testClusterConfig.setTopologyAwareEnabled(true);
Review comment:
Why do you set this field to false and back to true? Remove line 106?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
