narendly commented on a change in pull request #466: Integrate the WAGED
rebalancer with all the related components.
URL: https://github.com/apache/helix/pull/466#discussion_r325292549
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java
##########
@@ -124,7 +146,7 @@ private HelixProperty combineAssignments(String name,
HelixProperty property = new HelixProperty(name);
// Add each resource's assignment as a simple field in one ZNRecord
assignmentMap.forEach((resource, assignment) ->
property.getRecord().setSimpleField(resource,
- Arrays.toString(SERIALIZER.serialize(assignment.getRecord()))));
+ new String(SERIALIZER.serialize(assignment.getRecord()))));
Review comment:
Could we add a small comment saying that Arrays.toString doesn't work here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
