narendly commented on a change in pull request #466: Integrate the WAGED
rebalancer with all the related components.
URL: https://github.com/apache/helix/pull/466#discussion_r325300581
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/ConstraintBasedAlgorithmFactory.java
##########
@@ -19,22 +19,26 @@
* under the License.
*/
-import java.util.ArrayList;
import java.util.List;
+import com.google.common.collect.ImmutableList;
import org.apache.helix.controller.rebalancer.waged.RebalanceAlgorithm;
-import org.apache.helix.model.ClusterConfig;
public class ConstraintBasedAlgorithmFactory {
// TODO: the parameter comes from cluster config, will tune how these 2
integers will change the
// soft constraint weight model
public static RebalanceAlgorithm getInstance() {
- // TODO initialize constraints, depending on constraints implementations
PRs
- List<HardConstraint> hardConstraints = new ArrayList<>();
- List<SoftConstraint> softConstraints = new ArrayList<>();
+ List<HardConstraint> hardConstraints = ImmutableList
Review comment:
Question: is this factory meant to be static? How do we modify the
constraint based algorithm after-the-fact if the user wishes to use more
constraints or if we want to add more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
