narendly commented on a change in pull request #525: Add waged rebalancer 
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r338328841
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -444,6 +517,9 @@ private void 
refreshBaseline(ResourceControllerDataProvider clusterData,
         optimalAssignment.getOptimalResourceAssignment();
 
     LOG.info("Finish calculating. Time spent: {}ms.", 
System.currentTimeMillis() - startTime);
 
 Review comment:
   Nit: I usually find it more helpful to just say:
   
   "Finish calculateAssignment(). Took: {} ms.". Just to make it consistent 
with other logs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to