narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338370065
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/WagedRebalancer.java ########## @@ -0,0 +1,33 @@ +package org.apache.helix.controller.rebalancer.util; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Collection; + +import org.apache.helix.model.ResourceAssignment; + + +public class WagedRebalancer { Review comment: Either way, I get the feeling that creating a util class just for this is not necessary. Also just to share another thought, if you really needed a util class, you probably want to name it WagedRebalancerUtil, or better, WagedRebalancerMetricCalcuationUtil. The point I'm trying to get across here is that it shouldn't be called WagedRebalancer. Could you please try to contain this logic in some metric-related class? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
