narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r338909228
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -390,6 +402,14 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
Map<String, ResourceAssignment> newAssignment =
calculateAssignment(clusterData, clusterChanges,
resourceMap, activeNodes, currentBaseline,
currentBestPossibleAssignment);
+ // Asynchronously report baseline divergence metric before persistence
just in case persistence
Review comment:
"before persistence" is a little awkward - could we rephrase it to "before
persisting it to metadata store"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
