i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r346083403
########## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java ########## @@ -0,0 +1,117 @@ +package org.apache.helix.rest.server.resources.helix; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.WebApplicationException; +import javax.ws.rs.core.Response; + +import org.I0Itec.zkclient.exception.ZkMarshallingError; +import org.I0Itec.zkclient.serialize.ZkSerializer; +import org.apache.helix.AccessOption; +import org.apache.helix.PropertyPathBuilder; +import org.apache.helix.ZNRecord; +import org.apache.helix.manager.zk.ZkBaseDataAccessor; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +@Path("/clusters/{clusterId}/propertyStore") +public class PropertyStoreAccessor extends AbstractHelixResource { + private static Logger LOG = LoggerFactory.getLogger(PropertyStoreAccessor.class); + + private class PropertyStoreSerializer implements ZkSerializer { + private String _path; + + PropertyStoreSerializer(String path) { + _path = path; + } + + // used for writing the serialized content to property store path + @Override + public byte[] serialize(Object o) + throws ZkMarshallingError { + return (byte[]) o; + } + + // used for reading the raw content of property store path to ZnRecord format + @Override + public Object deserialize(byte[] bytes) + throws ZkMarshallingError { + try { + return ZNRecord.class.cast(bytes); + } catch (ClassCastException e) { + LOG.warn("The content of node at {} is not ZNRecord format", _path); + } + // fallback to a default and simple ZNRecord + ZNRecord znRecord = new ZNRecord(_path); + znRecord.setSimpleField(_path, new String(bytes)); + return znRecord; + } + + // The hash code is designed to be same for all PropertyStoreSerializer instance + @Override + public int hashCode() { + return "PropertyStoreSerializer".hashCode(); Review comment: done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
