i3wangyi commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r347039654
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java
##########
@@ -117,9 +121,20 @@ public HelixDataAccessor getDataAccssor(String
clusterName) {
}
}
+ public ZkBaseDataAccessor<ZNRecord> getZkBaseDataAccessor(ZkSerializer
serializer) {
Review comment:
For your idea, the propertyStoreAccessor needs to `new
ZkBaseDataAccessor(_zkAddress)`
every time, the `_zkAddress` is a private field. We need to understand
deeper that the ZkBaseDataAccessor constructor uses the same ZkConnection to
realize that we're not creating multiple ZkConnections. We'd better decouple
the logic and this kind of pre-knowledge.
My implementation of the proposed "zkBaseDataAccessor" pool also creates
only one instance of zkConnection for propertyStoreAccessor as well, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
