i3wangyi commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r347038187
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java
##########
@@ -130,6 +130,10 @@ private String errorMsgToJson(String error) {
}
protected Response JSONRepresentation(Object entity) {
+ if (entity == null) {
+ // return empty content when entity is null
+ return OK("");
+ }
Review comment:
Because I noticed getting the data from a non-existed path gives me the
string result
"null". It should not be the expected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
