jiajunwang commented on a change in pull request #644: Add new interface 
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r355695685
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
 ##########
 @@ -1098,9 +1098,10 @@ public void handleStateChanged(KeeperState state) {
   }
 
   @Override
-  public void handleNewSession() throws Exception {
-    LOG.info(
-        "Handle new session, instance: " + _instanceName + ", type: " + 
_instanceType);
+  public void handleNewSession(final String sessionId) throws Exception {
 
 Review comment:
   Is it possible that anyone extends ZkHelixManager in an application?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to