jiajunwang commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r355700124
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/client/HelixZkClient.java
##########
@@ -35,9 +36,47 @@
void unsubscribeDataChanges(String path, IZkDataListener listener);
- void subscribeStateChanges(final IZkStateListener listener);
+ /*
+ * This is for backwards compatibility.
+ *
+ * TODO: remove below default implementation when getting rid of I0Itec in
the new zk client.
+ */
+ default void subscribeStateChanges(final IZkStateListener listener) {
Review comment:
For a standard interface comment, we need to comment on how this one is
supposed to be implemented. Please put the todo and backward compatibility
after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
