jiajunwang commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r356881120
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackCache.java
##########
@@ -219,12 +219,27 @@ public void handleStateChanged(KeeperState state) throws
Exception {
}
- @Override
+ /**
+ * Handle new session without a session id passed in.
+ *
+ * @deprecated
+ * This is deprecated. It is kept for backward compatibility.
+ * Please use {@link #handleNewSession(String)}.
+ *
+ * @throws Exception
+ */
+ @Deprecated
public void handleNewSession() throws Exception {
// TODO Auto-generated method stub
}
+ @Override
+ public void handleNewSession(final String sessionId) throws Exception {
Review comment:
nit, for backward compatibility, shall we default implement it with the old
method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
