pkuwm commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r356194592
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackCache.java
##########
@@ -220,7 +220,7 @@ public void handleStateChanged(KeeperState state) throws
Exception {
}
@Override
- public void handleNewSession() throws Exception {
+ public void handleNewSession(final String sessionId) throws Exception {
Review comment:
Though handleNewSession() is not in the interface, we might want to keep the
method in ZkCallbackCache for backward compatibility in case any user class
extends this zk callback cache class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
